Skip to content

Remove wait-for-secret-scan job blocking Build and Deploy workflow - #19

Merged
No-Github merged 2 commits into
masterfrom
copilot/remove-wait-for-secret-scan-job
Jan 23, 2026
Merged

Remove wait-for-secret-scan job blocking Build and Deploy workflow#19
No-Github merged 2 commits into
masterfrom
copilot/remove-wait-for-secret-scan-job

Conversation

Copilot AI commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

The wait-for-secret-scan job blocks deployment waiting for a check "Scan for Secrets (AK/SK/Passwords)" that never runs against commits, causing workflow failures.

Changes

  • Removed wait-for-secret-scan job from .github/workflows/push-redc-templates.yml
  • Updated build-and-deploy dependency from needs: [wait-for-validation, wait-for-secret-scan] to needs: [wait-for-validation]

The secret scanning workflow in secret-scan.yml continues to run independently on push/PR events, but deployment no longer blocks on it.

Original prompt

Problem

The "Build and Deploy" workflow is failing in the wait-for-secret-scan job because it's waiting for a check named "Scan for Secrets (AK/SK/Passwords)" that never runs against the commits.

Error from logs:

The requested check was never run against this ref, exiting...
Process completed with exit code 1.

Failing job: https://github.com/wgpsec/redc-template/actions/runs/21282468439/job/61255526935

Commit ref: d1b88cd

Solution

Remove the wait-for-secret-scan job and its dependency from the workflow since the check it's waiting for doesn't exist in the repository.

Changes needed in .github/workflows/push-redc-templates.yml:

  1. Delete the entire wait-for-secret-scan job (lines 31-40)
  2. Update the build-and-deploy job's needs field to only depend on wait-for-validation (line 43)

Current code (lines 31-43):

  wait-for-secret-scan:
    runs-on: ubuntu-latest
    steps:
      - name: Wait for secret scanning to complete
        uses: lewagon/wait-on-check-action@v1.3.4
        with:
          ref: ${{ github.ref }}
          check-name: 'Scan for Secrets (AK/SK/Passwords)'
          repo-token: ${{ secrets.GITHUB_TOKEN }}
          wait-interval: 10

  build-and-deploy:
    needs: [wait-for-validation, wait-for-secret-scan]

Should become:

  build-and-deploy:
    needs: [wait-for-validation]

This will allow the workflow to proceed after the validation check completes, without waiting for the non-existent secret scanning check.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

The wait-for-secret-scan job was waiting for a check named "Scan for Secrets (AK/SK/Passwords)" that doesn't run against all commits, causing workflow failures. This change removes the job and its dependency from the build-and-deploy job.

Co-authored-by: No-Github <18167071+No-Github@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove wait-for-secret-scan job from build and deploy workflow Remove wait-for-secret-scan job blocking Build and Deploy workflow Jan 23, 2026
Copilot AI requested a review from No-Github January 23, 2026 10:20
@No-Github
No-Github marked this pull request as ready for review January 23, 2026 10:23
@No-Github
No-Github merged commit 1b5df52 into master Jan 23, 2026
2 checks passed
github-actions Bot pushed a commit that referenced this pull request Jan 23, 2026
…cret-scan-job

Remove wait-for-secret-scan job blocking Build and Deploy workflow 1b5df52
@No-Github
No-Github deleted the copilot/remove-wait-for-secret-scan-job branch January 23, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants