Update scrape benchmark to use http requests #109
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 44 44
Lines 5435 5435
Branches 5435 5435
=======================================
Hits 5097 5097
Misses 269 269
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bencher Report| Branch | johnsonw/scrape-metrics-update |
| Testbed | ci-runner |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Lower Boundary milliseconds (ms) (Limit %) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|---|
| jobstats 100 | 📈 view plot 🚷 view threshold | 1.49 ms(-0.15%)Baseline: 1.49 ms | 1.46 ms (98.08%) | 1.52 ms (97.83%) |
| jobstats 1000 | 📈 view plot 🚷 view threshold | 14.44 ms(-0.93%)Baseline: 14.58 ms | 14.18 ms (98.17%) | 14.98 ms (96.42%) |
|
| Branch | johnsonw/scrape-metrics-update |
| Testbed | ci-runner |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- RAM Hits (hits)
- Dw (writes)
- Estimated Cycles (cycles)
- D1 Miss Rate (misses (%))
- I1mr (misses (reads))
- D1mr (misses (reads))
- Dr (reads)
- ILmr (misses (reads))
- L1 Hits (hits)
- L1 Hit Rate (hits (%))
- I1 Miss Rate (misses (%))
- LL Hit Rate (hits (%))
- LL Hits (hits)
- LL Miss Rate (misses (%))
- RAM Hit Rate (hits (%))
- Total read+write (reads/writes)
- DLmw (misses (writes))
- LLi Miss Rate (misses (%))
- D1mw (misses (writes))
- LLd Miss Rate (misses (%))
- DLmr (misses (reads))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | D1 Miss Rate | misses (%) | D1mr | misses (reads) x 1e3 | D1mw | misses (writes) x 1e3 | DLmr | misses (reads) | DLmw | misses (writes) x 1e3 | Dr | reads x 1e6 | Dw | writes x 1e6 | Estimated Cycles | cycles x 1e6 | I1 Miss Rate | misses (%) | I1mr | misses (reads) x 1e3 | ILmr | misses (reads) | Instructions | Benchmark Result instructions x 1e6 (Result Δ%) | Lower Boundary instructions x 1e6 (Limit %) | Upper Boundary instructions x 1e6 (Limit %) | L1 Hit Rate | hits (%) | L1 Hits | hits x 1e6 | LL Hit Rate | hits (%) | LL Hits | hits x 1e3 | LL Miss Rate | misses (%) | LLd Miss Rate | misses (%) | LLi Miss Rate | misses (%) | RAM Hit Rate | hits (%) | RAM Hits | hits x 1e3 | Total read+write | reads/writes x 1e6 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| lustre_metrics::memory_benches::bench_encode_lustre_metrics with_setup:generate_records() | 📈 view plot | 0.91 % | 📈 view plot | 24.89 reads x 1e3 | 📈 view plot | 8.87 writes x 1e3 | 📈 view plot | 106.00 reads | 📈 view plot | 6.53 writes x 1e3 | 📈 view plot | 2.48 x 1e6 | 📈 view plot | 1.23 x 1e6 | 📈 view plot | 14.85 x 1e6 | 📈 view plot | 0.01 % | 📈 view plot | 1.01 reads x 1e3 | 📈 view plot | 858.00 reads | 📈 view plot 🚷 view threshold | 10.77 x 1e6(-44.00%)Baseline: 19.24 x 1e6 | 3.04 x 1e6 (28.18%) | 35.44 x 1e6 (30.40%) | 📈 view plot | 99.76 % | 📈 view plot | 14.46 x 1e6 | 📈 view plot | 0.19 % | 📈 view plot | 27.27 x 1e3 | 📈 view plot | 0.05 % | 📈 view plot | 0.18 % | 📈 view plot | 0.01 % | 📈 view plot | 0.05 % | 📈 view plot | 7.50 x 1e3 | 📈 view plot | 14.49 x 1e6 |
johnsonw
force-pushed
the
johnsonw/scrape-metrics-update
branch
24 times, most recently
from
4e7ec64 to
e3ff12d
Compare
johnsonw
force-pushed
the
johnsonw/scrape-metrics-update
branch
4 times, most recently
from
b235140 to
a0ed37b
Compare
Contributor
|
@johnsonw State of this? |
we are using in the service. This will make the benchmark closer to what we are doing in real life. This also takes into account gzip compression and other small details. Signed-off-by: William Johnson <[email protected]>
johnsonw
force-pushed
the
johnsonw/scrape-metrics-update
branch
from
a0ed37b to
4a496fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are using in the service. This will make the benchmark closer to
what we are doing in real life. This also takes into account gzip
compression and other small details.