Open
Conversation
## replace proc_macro_hack with proc_macro This allows nested macro executions (and therefore allows macros in other crates to abstract the gen macros). ## add rust-toolchain with nightly toolchain Otherwise, `cargo check --all-features` fails, because it attempts to enable the nightly feature and fails on stable. ## fix a few lints Similarly, `cargo check --all-features` enables `feature = "strict"`, which turns the warnings into hard errors. I'm not sure if they were present a year ago (and ignored), but they fail the build today with `--all-features`.
Collaborator
|
I can run the CI and aprove a PR but I don't feel comfortable merging and @whatisaphone has been busy with other things so it might be a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace proc_macro_hack with proc_macro
This allows nested macro executions (and therefore allows macros in other crates to abstract the gen macros).
add rust-toolchain with nightly toolchain
Otherwise,
cargo check --all-featuresfails, because it attempts to enable the nightly feature and fails on stable.fix a few lints
Similarly,
cargo check --all-featuresenablesfeature = "strict", which turns the warnings into hard errors. I'm not sure if they were present a year ago (and ignored), but they fail the build today with--all-features.