add no_std compatibility and remove Coroutine trait#36
Open
mrnerdhair wants to merge 4 commits intowhatisaphone:masterfrom
Open
add no_std compatibility and remove Coroutine trait#36mrnerdhair wants to merge 4 commits intowhatisaphone:masterfrom
no_std compatibility and remove Coroutine trait#36mrnerdhair wants to merge 4 commits intowhatisaphone:masterfrom
Conversation
|
I'd like to consider this library for a project of mine, and no_std would help for my needs. |
Author
|
@cameronelliott You don't need Arc or Mutex if you use the |
|
Hey, I'm interested in this PR, what prevents it to be merged? That would be so cool to have stable generators in my firmware code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to use this crate in an embedded environment, so I've gone through and replaced all referenced to
stdwithcoreexcept foralloc::sync::Arcwhich is required for thercandsyncengines andstd::sync::Mutexwhich is required for thesyncengine alone.Also, now that nightly's
Generatorhas been updated to take an argument, the customCoroutinetrait isn't required; I've removed it in favor of the baseGeneratortrait.(These could be split into single-purpose PRs easily if that would be preferable.)