Remove Metamodel, Optimization services and Package handling #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed OptimizerException and OptimizerKind from the Thrift service definition. - Deleted OptimizerStore service and its associated methods. - Removed optimizations_spec.rb and related tests for optimization endpoints. - Updated swagger documentation to remove references to SEGOMOE optimizer. - Deleted tests related to optimization controller and integration tests for SEGOMOE. - Cleaned up fixtures related to optimizations and roles. - Removed unused test helper methods and integration test base class.
- Deleted cicav_metamodel and cicav_metamodel2 related entries from fixtures. - Removed associated disciplines, operations, and roles. - Cleaned up surrogate and meta model tests. - Removed integration tests related to metamodel creation and sensitivity analysis. - Updated analysis tests to reflect the removal of metamodels. - Cleaned up discipline tests by removing metamodel copy tests. - Removed unnecessary variables and options related to cicav metamodel.
- Deleted AdministrationHandler class and its methods (ping, shutdown). - Removed Administration service definition and its associated Thrift files. - Cleaned up related constants and types in the services module. - Removed all generated files related to the Administration service.
- Removed the PackageExtractor and PackageFetcher classes as they are no longer needed. - Simplified the OpenmdaoGenerator to always generate package files without checking for existing packages. - Removed the Package model and its associated database table, along with all related tests and fixtures. - Updated the Analysis model to remove package-related associations and methods. - Adjusted policies and views to eliminate references to the package functionality. - Cleaned up tests to remove package-related assertions and dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for several legacy features and dependencies, updates Python version requirements, and cleans up related code and configuration files. The most important changes are grouped below by theme.
Removal of legacy features and dependencies:
app/controllers/api/v1/packages_controller.rbandapp/controllers/packages_controller.rbfiles, as well as thethriftgem and related installation steps from theGemfileandDockerfile. [1] [2] [3] [4] [5]app/controllers/api/v1/meta_models_controller.rbandapp/controllers/api/v1/prediction_qualities_controller.rbfiles. [1] [2] [3]app/controllers/api/v1/optimizations_controller.rb,app/controllers/optimizations_controller.rb, andapp/controllers/optimization_exports_controller.rb. [1] [2] [3]Configuration and dependency updates:
.github/workflows/tests.ymlfrom 3.11 to 3.12 and removed installation of editableservicesand requirements.VERSIONfile andCHANGELOGto reflect version 2.0.1 and document removed features. [1] [2]Code cleanup and simplification:
app/controllers/api/v1/exports_controller.rb. [1] [2]app/controllers/api/v1/sensitivity_analyses_controller.rb. [1] [2]app/controllers/api/v1/analyses_controller.rbto remove checks for packaged analyses.