Default empty string paths to URL's path #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct the algorithm as it incorrectly assumed that path could be null when in fact it's always a string. Tests: ... Closes #242.
DCtheTall
requested changes
Aug 8, 2025
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 12, 2025
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 12, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
|
This patch does not match what Chrome does. Chrome uses https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-layered-cookies#section-5.3.3 which is currently not exported, but I suppose it should be. Edit: it should now be good. |
annevk
added
the
do not merge yet
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 12, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 13, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
annevk
removed
the
do not merge yet
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 14, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 14, 2025
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Aug 14, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by Rupin Mittal. Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264 Canonical link: https://commits.webkit.org/298681@main
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Aug 25, 2025
…ulting, a=testonly Automatic update from web-platform-tests Cookie Store API: empty string path defaulting For whatwg/cookiestore#283. -- wpt-commits: 65753567cf5b437a93568ec134eb76b2c75ced7d wpt-pr: 54264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correct the algorithm as it incorrectly assumed that path could be null when in fact it's always a string.
Tests: web-platform-tests/wpt#54264
Closes #242.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff