Skip to content

Need to catch exceptions to report them #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

Need to catch exceptions to report them #889

merged 1 commit into from
Nov 9, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 8, 2020 •
edited by pr-preview bot
Loading

Now that the default semantics are to throw, we need to be more explicit about catching.

Preview | Diff

@annevk
Need to catch exceptions to report them
3b1370a 
Now that the default semantics are to throw, we need to be more explicit about catching.
@annevk annevk requested a review from domenic November 6, 2020 12:36
@annevk
Copy link
Member Author

annevk commented Nov 6, 2020

(Maybe not merge this before #918 due to new reference errors.)

@annevk annevk merged commit 52f7a52 into master Nov 9, 2020
@annevk annevk deleted the annevk/catch-exceptions branch November 9, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic