Add WebDriver BiDi network request logging #1540

jgraham · 2022-11-18T10:24:49Z

At least two implementers are interested (and none opposed):
- Changes landed in WebDriver-BiDi with agreement in Browser Testing and Tools WG.
Tests are written and can be reviewed and commented upon at:
- https://wpt.fyi/results/webdriver/tests/bidi/network?label=experimental&label=master&aligned (there's no normative changes to fetch behaviour other than when WebDriver is enabled).
Implementation bugs are filed:
- Chromium: …
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1790366 (and similarly for other events)
MDN issue is filed: …
- No WebDriver BiDi documentation on MDN yet.
  (See WHATWG Working Mode: Changes for more details.)

Preview | Diff

This commit can be reverted once whatwg/fetch#1540 lands

annevk

Thanks for tackling this. Looks reasonable overall, but I found some issues.

fetch.bs

* Add WebDriver BIDI needed for whatwg/fetch#1540 (comment) * Update refs/biblio.json Co-authored-by: François Daoust <[email protected]> --------- Co-authored-by: François Daoust <[email protected]>

annevk

@jgraham apologies for the delay. Please resolve existing comment threads and maybe ping me if you haven't seen an update in a while.

I was wondering if there was a high-level description available somewhere so I can verify the various calls happen at the right time. Also happy to trust you, but it might help to have some additional review?

fetch.bs

annevk

Question about the overview still stands. Looks good otherwise.

fetch.bs

annevk · 2024-02-01T11:16:40Z

fetch.bs

- <a for=request>body</a>.
+ <a for=request>body</a> and <a for=request>id</a>.
+
+ <li><p>Set <var>newRequest</var>'s <a for=request>id</a> to a new unique string.


Is this a UUID in practice? Do we just want to settle on that?

It doesn't seem to be at the moment. I'd happily require a UUID here, but I feel like we don't quite have consensus on UUIDs everywhere yet.

@annevk would you mind taking another look at this PR? Thanks!

whimboo · 2024-05-23T06:40:13Z

@annevk gently ping for review. Thanks.

annevk · 2024-06-12T11:55:17Z

Hey @whimboo @jgraham did my question about some kind of overview get lost?

I also wonder if @noamr perhaps wants to take a look.

I have a number of nits in mind looking at the text now, but I can push a commit for that once the higher level concern is resolved.

jgraham · 2024-06-12T13:22:20Z

w3c/webdriver-bidi#204 has a brief overview in the description. I don't know if you wanted more detail than that.

I think we know at this point there are some problems e.g. w3c/webdriver-bidi#722 which covers what happens with auth requests (technically specified, but probably not in a way that's easy to use).

annevk · 2024-06-12T15:35:43Z

Thanks, that helps a lot! I left some questions in the authentication issue. I think we should probably try to solve for the model we want first. At least it doesn't make much sense to me to land something we don't feel confident about.

sadym-chromium · 2025-07-23T12:06:16Z

fetch.bs


+   <!-- After this point the request is not further modified before being either
+        retrieved from the cache or sent -->
+   <li><p>Run the <a>WebDriver BiDi before request sent</a> steps with <var>request</var>.


@jgraham does it intentionally use request instead of httpRequest?

OrKoN · 2025-10-12T13:53:24Z

fetch.bs

+
+     <li><p>If <var>response</var> is a <a>network error</a>, run
+     the <a>WebDriver BiDi fetch error</a> steps with <var>request</var>. Otherwise
+     run the <a>WebDriver BiDi response completed</a> steps with


I failed to find a conclusive answer so far so posting a question here: do we expect this to be called if the client never reads the response body (e.g., void fetch('...'))? As far as I see, this is used as a flush algorithm for a stream pipe and it looks like it might not get called if the body is not read by the client until the browser decides to clean up the stream. cc @jgraham @sadym-chromium @juliandescottes

jgraham mentioned this pull request Nov 18, 2022

Add Network module w3c/webdriver-bidi#204

Merged

jgraham force-pushed the webdriver_request_logging branch from fff0efb to 7884a67 Compare December 20, 2022 09:43

jgraham force-pushed the webdriver_request_logging branch from 7884a67 to 4fa3194 Compare January 20, 2023 14:28

jgraham added a commit to w3c/webdriver-bidi that referenced this pull request Mar 8, 2023

Remove link to term that will later be defined in fetch

599474d

This commit can be reverted once whatwg/fetch#1540 lands

jgraham added a commit to w3c/webdriver-bidi that referenced this pull request Mar 8, 2023

Remove link to term that will later be defined in fetch

e09c908

This commit can be reverted once whatwg/fetch#1540 lands

jgraham added a commit to w3c/webdriver-bidi that referenced this pull request Mar 29, 2023

Remove link to term that will later be defined in fetch

05062e2

This commit can be reverted once whatwg/fetch#1540 lands

jgraham added a commit to w3c/webdriver-bidi that referenced this pull request Mar 29, 2023

Remove link to term that will later be defined in fetch

057aa4c

This commit can be reverted once whatwg/fetch#1540 lands

jgraham added a commit to w3c/webdriver-bidi that referenced this pull request Mar 30, 2023

Remove link to term that will later be defined in fetch

e97c0af

This commit can be reverted once whatwg/fetch#1540 lands

jgraham closed this May 15, 2023

jgraham reopened this May 15, 2023

jgraham force-pushed the webdriver_request_logging branch 2 times, most recently from 4eb1c56 to 968dea4 Compare May 19, 2023 08:37

jgraham marked this pull request as ready for review May 19, 2023 08:40

annevk reviewed May 22, 2023

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

jgraham force-pushed the webdriver_request_logging branch from 968dea4 to 5df348c Compare May 22, 2023 12:53

dontcallmedom mentioned this pull request May 22, 2023

Add WebDriver BIDI tobie/specref#746

Merged

jgraham force-pushed the webdriver_request_logging branch from 5df348c to f010d62 Compare July 21, 2023 09:18

jgraham requested a review from annevk July 21, 2023 09:18

jgraham force-pushed the webdriver_request_logging branch from f010d62 to e5bc282 Compare July 21, 2023 09:24

jgraham closed this Jul 27, 2023

jgraham reopened this Jul 27, 2023

jgraham force-pushed the webdriver_request_logging branch 2 times, most recently from 34edf7e to 2998bd1 Compare July 27, 2023 15:38

annevk reviewed Sep 28, 2023

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

jgraham force-pushed the webdriver_request_logging branch 3 times, most recently from 2747ae7 to d0c7b8a Compare January 4, 2024 12:35

jgraham requested a review from annevk January 5, 2024 12:25

annevk reviewed Feb 1, 2024

View reviewed changes

Add WebDriver BiDi network request logging

a808110

jgraham force-pushed the webdriver_request_logging branch from d0c7b8a to a808110 Compare April 9, 2024 11:43

jgraham requested a review from annevk April 9, 2024 11:43

jgraham mentioned this pull request Jul 17, 2024

Webdriver cache mode #1756

Draft

5 tasks

OrKoN mentioned this pull request Sep 27, 2024

Support interception only for requests that are actually sent over the wire w3c/webdriver-bidi#792

Open

juliandescottes mentioned this pull request Jul 16, 2025

emulation.setUserAgentOverride w3c/webdriver-bidi#947

Merged

sadym-chromium reviewed Jul 23, 2025

View reviewed changes

This was referenced Sep 29, 2025

Add support for request dataType to network data collection w3c/webdriver-bidi#1011

Merged

Call webdriver bidi hooks to clone request and response bodies #1860

Draft

css-meeting-bot mentioned this pull request Oct 8, 2025

Clarify network events received for authentication attempts w3c/webdriver-bidi#722

Open

OrKoN reviewed Oct 12, 2025

View reviewed changes

OrKoN mentioned this pull request Nov 7, 2025

network.responseCompleted is emitted too early GoogleChromeLabs/chromium-bidi#3574

Open

Add WebDriver BiDi network request logging #1540

Are you sure you want to change the base?

Add WebDriver BiDi network request logging #1540

Uh oh!

Conversation

jgraham commented Nov 18, 2022 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

annevk Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

jgraham Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

whimboo May 8, 2024

Choose a reason for hiding this comment

Uh oh!

whimboo commented May 23, 2024

Uh oh!

annevk commented Jun 12, 2024

Uh oh!

jgraham commented Jun 12, 2024

Uh oh!

annevk commented Jun 12, 2024

Uh oh!

sadym-chromium Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

OrKoN Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

jgraham commented Nov 18, 2022 •

edited by pr-preview bot

Loading