use script's baseurl for cssstylesheets #11706
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -117337,14 +117337,18 @@ document.querySelector("button").addEventListener("click", bound); | |||||
| <li><p>Set <var>script</var>'s <span data-x="concept-script-settings-object">settings | ||||||
| object</span> to <var>settings</var>.</p></li> | ||||||
|
|
||||||
| <li><p>Let <var>baseUrl</var> be <var>script</var>'s <span data-x="concept-script-base-url">base | ||||||
| URL</span>. | ||||||
|
|
||||||
| <li><p>Set <var>script</var>'s <span data-x="concept-script-base-url">base URL</span> and | ||||||
| <span data-x="concept-script-script-fetch-options">fetch options</span> to null.</p></li> | ||||||
|
|
||||||
| <li><p>Set <var>script</var>'s <span data-x="concept-script-parse-error">parse error</span> and | ||||||
| <span data-x="concept-script-error-to-rethrow">error to rethrow</span> to null.</p></li> | ||||||
|
|
||||||
| <li><p>Let <var>sheet</var> be the result of running the steps to <span>create a constructed | ||||||
| <code>CSSStyleSheet</code></span> with a dictionary with: | ||||||
|
||||||
| <code>CSSStyleSheet</code></span> with a dictionary with: | |
| <code>CSSStyleSheet</code></span> with |
(might have to line break differently after applying this)
There was a problem hiding this comment.
I don't mind changing the line wrapping but the entire «[ .* ]» chunk will not fit on the 100 column break point on the line above, so it feels right to keep it on one line.
I see other examples do break on «[, so I can put that on the line above, but it feels odd to me.
There was a problem hiding this comment.
I think we do break inside literals just like we break on whitespace elsewhere, but it might not matter much if we end up applying @zcorpan's rewrapper script.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure
script'sbaseURLis valid here -- we just createdscriptin the first step of this algorithm and haven't initialized that field yet.I see that other "create a module script" algos take the baseURL as a parameter, e.g. see create a javascript module script. It looks to me like "create a CSS module script" also needs that parameter. We'd pass in the "response's URL" as the baseURL here in the same way as is done for WASM module scripts and JS module scripts nearby.
It's a little more plumbing than I thought it'd be in #11629 (comment) but I hadn't realized at the time that the CSS module script's baseURL just gets set to null.