Open
Conversation
Contributor
|
The only thing I really dislike about this is that it's forcing articles to the end of the line, etc. Technically we could solve this by using non-breaking spaces, but perhaps it's not that important for these docs. |
Contributor
Author
|
As I understand wrapping only based on word length is the general approach in books, magazines and even the tex rendering algorithm, so I'd align with that. |
Member
|
@konstin can you solve the CI lint check and address the conflict ? |
konstin
force-pushed
the
konsti/use-prettier-for-markdown-formatting
branch
from
bd4d468 to
12bc2bf
Compare
Manually wrapping the lines in markdown files is cumbersome, so I've added prettier which prose-wraps and formats those files for us. It also gives us consistency between the files that are currently not wrapped at a line length and those that are.
konstin
force-pushed
the
konsti/use-prettier-for-markdown-formatting
branch
from
12bc2bf to
31cbd05
Compare
Contributor
Author
|
Done |
DEKHTIARJonathan
force-pushed
the
main
branch
4 times, most recently
from
e60ef85 to
6d15a1f
Compare
DEKHTIARJonathan
force-pushed
the
main
branch
3 times, most recently
from
7b55748 to
22367bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually wrapping the lines in markdown files is cumbersome, so I've added prettier which prose-wraps and formats those files for us. It also gives us consistency between the files that are currently not wrapped at a line length and those that are.
The only text change is the new "Contributing" section that explains how to run prettier: