Null variant labels #110
Merged
Null variant labels #110
+190
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are no longer using it as a label, we do not need a recognizable special value here. Instead, just use hash of an empty string, so we can remove the special casing in code.
There was a problem hiding this comment.
I like the approach but I think letting the user to potentially provide custom label with null-variant is opening the door to bugs and implementation errors.
I would far prefer to take a more "direct" approach.
If you declare a null variant. Either I ignore you custom variant requested or you immediately get a validation error.
I think we would gain to be more drastic. If it's a guarantee then it's a guarantee - the user should not have to / and should not be allowed to potentially do otherwise
|
You can merge once you're happy with the changes - I'm happy with the implementation (aside of being more drastic in the approach) |
DEKHTIARJonathan
approved these changes
Aug 12, 2025
Signed-off-by: Michał Górny <[email protected]>
Remove `NULL_VARIANT_HASH` since it resembles magic constant too much. In the few places where we need it, either call hash directly, or get it from VariantDescription. Signed-off-by: Michał Górny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_variant_label()helper for convenience.nulllabel for null variants.sha256("").