Skip to content

Bug #234 was fixed in cd-paranoia 10.2+2.0.2; hide the warning in >=10.3 #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lcorbasson wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Bug #234 was fixed in cd-paranoia 10.2+2.0.2; hide the warning in >=10.3 #673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b512d57
Bug #234 was fixed in cd-paranoia 10.2+2.0.2; hide the warning in >=10.3
lcorbasson Feb 9, 2026
045c9b6
No longer rely on
lcorbasson Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions whipper/program/cdparanoia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
import tempfile
import time

from packaging.version import Version

from whipper.common import common
from whipper.common import task as ctask
from whipper.extern import asyncsub
Expand Down Expand Up @@ -284,16 +286,20 @@ def start(self, runner):
self.path])
logger.debug('running %s', (" ".join(argv), ))
if self._offset > 587:
logger.warning(
"because of a cd-paranoia upstream bug whipper may fail to "
"work correctly when using offset values > 587 (current "
"value: %d) and print warnings like this: 'file size 0 did "
"not match expected size'. For more details please check the "
"following issues: "
"https://github.com/whipper-team/whipper/issues/234 and "
"https://github.com/rocky/libcdio-paranoia/issues/14",
self._offset
)
if Version(_CDPARANOIA_VERSION) <= Version('10.2'):
# the bug was fixed in cd-paranoia 10.2+2.0.2
# but all cd-paranoia 10.2 releases have the same version number,
# so we match up to 10.2
logger.warning(
"because of a cd-paranoia upstream bug whipper may fail to "
"work correctly when using offset values > 587 (current "
"value: %d) and print warnings like this: 'file size 0 did "
"not match expected size'. For more details please check the "
"following issues: "
"https://github.com/whipper-team/whipper/issues/234 and "
"https://github.com/rocky/libcdio-paranoia/issues/14",
self._offset
)
if stopTrack == 99:
logger.warning(
"because of a cd-paranoia upstream bug whipper may fail to "
Expand Down Expand Up @@ -580,6 +586,12 @@ def getCdParanoiaVersion():
return getter.get()


try:
_CDPARANOIA_VERSION = getCdParanoiaVersion().split(' ')[1]
except IndexError:
_CDPARANOIA_VERSION = '0'


_OK_RE = re.compile(r'Drive tests OK with Paranoia.')
_WARNING_RE = re.compile(r'WARNING! PARANOIA MAY NOT BE')
_ABORTING_RE = re.compile(r'aborting test\.')
Expand Down