Fix text formatting for track rip failures#680
Open
drjaska wants to merge 1 commit intowhipper-team:developfrom
Open
Fix text formatting for track rip failures#680drjaska wants to merge 1 commit intowhipper-team:developfrom
drjaska wants to merge 1 commit intowhipper-team:developfrom
Conversation
When a track fails to rip, instead of printing > track %d failed to rip. 5 we should print the following > track 5 failed to rip. Signed-off-by: drjaska <drjaska83@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Author
|
Looking at this closer, I may have confused Python string concatenation syntax and assumed that a bug in a previous Debian package had not been fixed in the current codebase. The code should, as is, provide a format string and an argument for it to the logger. Without testing with a scratched disc I can't tell whether this is a meaningful change or not in the current pre-release anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a track fails to rip, instead of printing
we should print the following