Migrate license metadata to SPDX expression#685
Open
gilbsgilbs wants to merge 2 commits intowhipper-team:developfrom
Open
Migrate license metadata to SPDX expression#685gilbsgilbs wants to merge 2 commits intowhipper-team:developfrom
gilbsgilbs wants to merge 2 commits intowhipper-team:developfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
"License :: OSI Approved :: GNU General Public License v3" is not a valid trove classifier; the correct value per the trove-classifiers spec is "License :: OSI Approved :: GNU General Public License v3 (GPLv3)". This causes build failures for distribution package maintainers who use `python -m build --no-isolation`, which exposes the build to a system-installed validate-pyproject that enforces the classifier spec. Isolated builds are unaffected. Signed-off-by: Gilbert Gilb's <gilbsgilbert@gmail.com>
Replace the deprecated `license = {file = "LICENSE"}` TOML table with a
plain SPDX expression (`license = "GPL-3.0-only"`) and an explicit
`license-files` entry, and drop the now-redundant license trove
classifier.
Fixes deprecation warnings from setuptools >= 77.
Signed-off-by: Gilbert Gilb's <gilbsgilbert@gmail.com>
gilbsgilbs
force-pushed
the
trove-classifier
branch
from
bbed04f to
2923ce6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project was using an incorrect trove classifier for GPLv3 (
License :: OSI Approved :: GNU General Public License v3instead ofLicense :: OSI Approved :: GNU General Public License v3 (GPLv3))¹, which was leading to build failures with non-isolated builds. We could update just this classifier, however license trove classifiers are now deprecated, and the modern way of declaring licenses is though SPDX expressions² ³.license = {file = "LICENSE"}with a plain SPDX expressionlicense-filesentry to make sure it's included in builds[1] https://pypi.org/classifiers/#:~:text=GPLv3
[2] https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files
[3] https://peps.python.org/pep-0639/