Skip to content

DRAFT: AO star (DO NOT MERGE YET)#20

Draft
marfvr wants to merge 2 commits intomainfrom
feat/ao-star
Draft

DRAFT: AO star (DO NOT MERGE YET)#20
marfvr wants to merge 2 commits intomainfrom
feat/ao-star

Conversation

@marfvr
Copy link
Copy Markdown
Member

@marfvr marfvr commented Aug 22, 2021

DO NOT MERGE YET

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marfvr marfvr changed the title DRAFT: AO star DRAFT: AO star (DO NOT MERGE YET) Aug 22, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2021

Codecov Report

Merging #20 (9958a74) into develop (815f37c) will decrease coverage by 0.84%.
The diff coverage is n/a.

❗ Current head 9958a74 differs from pull request most recent head 6f75964. Consider uploading reports for the commit 6f75964 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #20      +/-   ##
===========================================
- Coverage    41.00%   40.15%   -0.85%     
===========================================
  Files           59       33      -26     
  Lines         3939     2276    -1663     
  Branches      1915      932     -983     
===========================================
- Hits          1615      914     -701     
+ Misses         676      657      -19     
+ Partials      1648      705     -943     
Flag Coverage Δ
cynthia-core ?
cynthia-logic 35.78% <ø> (ø)
cynthia-parser 40.15% <ø> (ø)
cynthia-utils 41.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/utils/include/cynthia/utils.hpp 41.66% <ø> (-21.97%) ⬇️
libs/logic/src/print.cpp 0.00% <0.00%> (-58.34%) ⬇️
libs/logic/src/nnf.cpp 30.30% <0.00%> (-47.62%) ⬇️
libs/logic/include/cynthia/logic/base.hpp 26.92% <0.00%> (-42.31%) ⬇️
libs/logic/src/ltlf.cpp 28.88% <0.00%> (-16.67%) ⬇️
libs/parser/include/cynthia/parser/driver.hpp 50.00% <0.00%> (-16.67%) ⬇️
libs/parser/include/cynthia/parser/lexer.l 84.84% <0.00%> (-6.33%) ⬇️
libs/parser/include/cynthia/parser/parser.yy 8.33% <0.00%> (-4.17%) ⬇️
libs/logic/src/duality.cpp 44.15% <0.00%> (-3.29%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815f37c...6f75964. Read the comment docs.

@marfvr marfvr marked this pull request as draft August 22, 2021 18:02
Base automatically changed from develop to main December 21, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant