Skip to content

added feature to compute the hamming distance of a formula#26

Closed
Shufang-Zhu wants to merge 2 commits intodevelopfrom
feat/heuristics-hamming-distance
Closed

added feature to compute the hamming distance of a formula#26
Shufang-Zhu wants to merge 2 commits intodevelopfrom
feat/heuristics-hamming-distance

Conversation

@Shufang-Zhu
Copy link
Copy Markdown
Member

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Shufang-Zhu Shufang-Zhu requested a review from marfvr October 5, 2021 15:31
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 5, 2021

Codecov Report

Merging #26 (2056c4d) into develop (d735313) will increase coverage by 0.17%.
The diff coverage is 48.69%.

❗ Current head 2056c4d differs from pull request most recent head 0edd228. Consider uploading reports for the commit 0edd228 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #26      +/-   ##
===========================================
+ Coverage    42.05%   42.22%   +0.17%     
===========================================
  Files           64       66       +2     
  Lines         4304     4419     +115     
  Branches      2060     2106      +46     
===========================================
+ Hits          1810     1866      +56     
- Misses         758      774      +16     
- Partials      1736     1779      +43     
Flag Coverage Δ
cynthia-core 42.22% <48.69%> (+0.17%) ⬆️
cynthia-logic 36.23% <ø> (ø)
cynthia-parser 40.36% <ø> (ø)
cynthia-utils 44.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/core/tests/unit/test_hamming_distance.cpp 35.08% <35.08%> (ø)
libs/core/src/hamming_distance.cpp 62.06% <62.06%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d735313...0edd228. Read the comment docs.

@marfvr
Copy link
Copy Markdown
Member

marfvr commented Nov 15, 2021

Closing in favor of #27

@marfvr marfvr closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants