Adds parameter to override default timeout when searching for the rootSelector element #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When at 0 seconds, the "root" variable is undefined. Adding a delay allows the page to render before searching for the rootSelector element.
theonlyriddle
changed the title
|
yes, this is very useful (and necessary) |
jeanfredrik
approved these changes
Apr 8, 2025
Member
jeanfredrik
left a comment
jeanfredrik
left a comment
There was a problem hiding this comment.
Thank you for this contribution!
Member
|
Can you rebase this PR to resolve the conflicts? @theonlyriddle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When at 0 seconds, the "root" variable is undefined. Adding a delay allows the page to render before searching for the rootSelector element.