Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the go-github library from v47 to v80, updates Go from version 1.23 to 1.25, and pins GitHub Actions to specific commit SHAs. The upgrade includes adapting to API changes in the newer go-github version, such as switching from deprecated functions to new methods and updating type signatures.
Key Changes:
- Upgraded
go-githubfrom v47 to v80 across all Go source files - Updated Go version from 1.23 to 1.25 in go.mod and Dockerfile
- Replaced deprecated
github.String()withgithub.Ptr()and adapted to new API patterns - Pinned all GitHub Actions to specific commit SHAs with version comments
Reviewed changes
Copilot reviewed 22 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Go version to 1.25 and upgraded dependencies including go-github to v80 |
| Dockerfile | Updated base image to golang:1.25 |
| pkg/gh/github.go | Replaced deprecated NewEnterpriseClient() with NewClient().WithEnterpriseURLs() |
| pkg/gh/jwt.go | Adapted token expiration handling to use GetTime() method |
| pkg/gh/runner.go | Updated ListOptions to ListRunnersOptions with nested structure |
| pkg/starter/starter.go | Replaced github.String() with github.Ptr() |
| internal/util/util.go | Switched from golang.org/x/exp/rand to math/rand/v2 |
| .github/workflows/*.yaml | Pinned all GitHub Actions to specific commit SHAs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.