Skip to content

Commit 8c8f0e4

Browse files
Copilotka8725
andcommitted
Fix rubocop AbcSize offense by refactoring default_settings
Co-authored-by: ka8725 <243846+ka8725@users.noreply.github.com>
1 parent 5f0e5ca commit 8c8f0e4

File tree

1 file changed

+22
-6
lines changed

1 file changed

+22
-6
lines changed

lib/actual_db_schema/configuration.rb

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,34 @@ def fetch(key, default = nil)
3333

3434
def default_settings
3535
{
36-
enabled: Rails.env.development?,
37-
auto_rollback_disabled: ENV["ACTUAL_DB_SCHEMA_AUTO_ROLLBACK_DISABLED"].present?,
38-
ui_enabled: Rails.env.development? || ENV["ACTUAL_DB_SCHEMA_UI_ENABLED"].present?,
39-
git_hooks_enabled: ENV["ACTUAL_DB_SCHEMA_GIT_HOOKS_ENABLED"].present?,
36+
enabled: enabled_by_default?,
37+
auto_rollback_disabled: env_enabled?("ACTUAL_DB_SCHEMA_AUTO_ROLLBACK_DISABLED"),
38+
ui_enabled: ui_enabled_by_default?,
39+
git_hooks_enabled: env_enabled?("ACTUAL_DB_SCHEMA_GIT_HOOKS_ENABLED"),
4040
multi_tenant_schemas: nil,
41-
console_migrations_enabled: ENV["ACTUAL_DB_SCHEMA_CONSOLE_MIGRATIONS_ENABLED"].present?,
41+
console_migrations_enabled: env_enabled?("ACTUAL_DB_SCHEMA_CONSOLE_MIGRATIONS_ENABLED"),
4242
migrated_folder: ENV["ACTUAL_DB_SCHEMA_MIGRATED_FOLDER"].present?,
43-
migrations_storage: ENV.fetch("ACTUAL_DB_SCHEMA_MIGRATIONS_STORAGE", "file").to_sym,
43+
migrations_storage: migrations_storage_from_env,
4444
excluded_databases: parse_excluded_databases_env
4545
}
4646
end
4747

48+
def enabled_by_default?
49+
Rails.env.development?
50+
end
51+
52+
def ui_enabled_by_default?
53+
Rails.env.development? || env_enabled?("ACTUAL_DB_SCHEMA_UI_ENABLED")
54+
end
55+
56+
def env_enabled?(key)
57+
ENV[key].present?
58+
end
59+
60+
def migrations_storage_from_env
61+
ENV.fetch("ACTUAL_DB_SCHEMA_MIGRATIONS_STORAGE", "file").to_sym
62+
end
63+
4864
def parse_excluded_databases_env
4965
return [] unless ENV["ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES"].present?
5066

0 commit comments

Comments
 (0)