Merged
Conversation
iisakkirotko
force-pushed
the
feat-xr-viewer
branch
2 times, most recently
from
ea0c141 to
d40a3a0
Compare
Contributor
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
Let's discuss the props/traits comment.
Also, would be good to suggest using ngrok because that might be easier than caddy and does not require you to be on the same network.
| def __init__(self, children=[]): | ||
| super().__init__( | ||
| _type="meshPhongMaterial", | ||
| props=dict(color=self.color, opacity=self.opacity, transparent=True), |
Contributor
There was a problem hiding this comment.
No need to add this, we either use the trait, but then we need to also support the setColor on the js side:
https://github.com/widgetti/ipyreact/?tab=readme-ov-file#summary
Or, we
Suggested change
| props=dict(color=self.color, opacity=self.opacity, transparent=True), |
We now separate three.js and the @react-three packages into their own bundles to improve extendability.
iisakkirotko
force-pushed
the
feat-xr-viewer
branch
from
f2ab704 to
e9e5c66
Compare
Co-authored-by: Maarten Breddels <maartenbreddels@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more issue I can think of:
TODO: