Add MDI and grid layouts if app has existing viewers#21
Open
Carifio24 wants to merge 3 commits intowidgetti:masterfrom
Open
Add MDI and grid layouts if app has existing viewers#21Carifio24 wants to merge 3 commits intowidgetti:masterfrom
Carifio24 wants to merge 3 commits intowidgetti:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the
GlueAppcomponent for another project, I realized that if the app already has viewers, MDI and grid items aren't added to the relevant layout lists. This PR fixes that. I refactored out the logic for generating the layouts so that it only needs to live in one place.Also, none of the viewers would display for me unless I removed the
position: relativein the root MDI view, hence that change.