Skip to content

fix: revert css extraction #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariobuikhuizen merged 1 commit into from
Feb 27, 2025
Merged

fix: revert css extraction #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion js/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.17.2",
"eslint-plugin-vue": "^5.2.2",
"mini-css-extract-plugin": "^2.9.2",
"npm-run-all": "^4.1.5",
"postcss-loader": "^8.1.1",
"postcss-scopify": "^1.0.0",
Expand Down
18 changes: 1 addition & 17 deletions js/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
var path = require("path");
var version = require("./package.json").version;
const MiniCssExtractPlugin = require("mini-css-extract-plugin");

// Custom webpack rules are generally the same for all webpack bundles, hence
// stored in a separate local variable.
Expand Down Expand Up @@ -172,23 +171,8 @@ module.exports = [
},
devtool: "source-map",
module: {
rules: [
{
test: /\.css$/,
use: [MiniCssExtractPlugin.loader, "css-loader", "postcss-loader"],
},
{
test: /\.(woff|woff2|eot|ttf|otf)$/,
type: "asset/resource",
},
],
rules,
},
// we extract the CSS to a separate file, since we might want to import it separately for global use
plugins: [
new MiniCssExtractPlugin({
filename: "jupyter-vuetify.min.css",
}),
],
externals: ["@jupyter-widgets/base", "@jupyterlab/apputils", "jupyter-vue"],
resolve: {
alias: {
Expand Down
Loading