Fix loading games that require an IOS reload on USB1#57
Fix loading games that require an IOS reload on USB1#57MapleHinata wants to merge 1 commit intowiidev:enhancedfrom
Conversation
|
Hey, could you tell me which cIOS you're using and name a game that might have this issue? I've already made a lot of changes to USB drive mounting, reading, and writing for the next major release, so I'll need to verify whether this change is still required. However, it's worth noting that USB1 support is currently in a deprecated state, since I only offer support for modern versions of the d2x cIOS. |
|
Hi, thanks for looking into it!, I was using d2x-v10-beta53-alt on an original Wii, and an easy way to test this would be the any of the Just Dance games with Microphone support (Just Dance 2014 to 2017), since they rely on reloading to IOS 57, and it's on those games I encountered this issue.
Ok but...I checked the changes between d2x-v11 and d2x-v10 and those are very minor, basically being:
I don't see anything in here that makes d2x-v11 any more modern than d2x-v10-alt for most use cases, and at a glance, they seem trivial to backport to d2x-alt, too. If you really need those EmuNAND fixes and vWii changes that much, I'll port them to d2x-alt, I just didn't bother because they don't really apply to me, and d2x-v10-alt just worked on any disc game I threw at it with USB Loader GX after those changes. |
|
I just want to be clear that I won't go out of my way to support other cIOS, since I only want to debug issues from people using my version, as that makes things easier for me and anyone else trying to help. However, that isn't to say that I won't apply small fixes within the loader if doing so improves compatibility with other cIOS versions.
The changes might look minor, but they have a significant impact on game compatibility.
The alt branch doesn't have fully working EmuNAND support, and its USB drive compatibility is worse. That's why it's never been recommended, especially as your main cIOS. The next USB Loader GX update drops support for NTFS and EXT and adds support for exFAT and large (3TB+) hard drives. So there are going to be a lot of file system changes, and I've only tested the changes against d2x-v11-beta3 and the upcoming version of the cIOS. And yes, the cIOS update will also include a lot of file system changes, among other things. When I get a moment I'll verify if this patch is still required, or if even more changes would be necessary now that I've changed so much 😅 |
On the latest release, trying to load any game that requires an IOS reload on a device connected over USB1 fails, due to USBStorage2 not being properly clean up prior to the reload, with the USB device failing to be re-initialized after the reload.
This PR fixes that by properly unmounting all USB devices and setting the USB port back to zero on
USBStorage2_Deinit, allowing USB re-init to work after a reload.