Update JWB interface based on Fandom's one, major changes#35
Open
LeviPesin wants to merge 10 commits intowikimedia-gadgets:masterfrom
Open
Update JWB interface based on Fandom's one, major changes#35LeviPesin wants to merge 10 commits intowikimedia-gadgets:masterfrom
LeviPesin wants to merge 10 commits intowikimedia-gadgets:masterfrom
Conversation
Author
|
@Joeytje50 I forgot to ping you, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thanks for the wonderful tool! I have used it previously for about an year on Fandom and have introduced a few Russian Wikipedia users to it now.
Most of this pull request includes the updates to the JWB interface -- modern HTML and CSS, including accessibility features. These changes were originally based on such changes by Fandom user Polymeric, though with very many improvement by myself.
There are some additional minor changes included:
You can find all the changes in these pages histories.
The script has been tested by three users on multiple wikis (Russian Wikipedia, Russian Wikinews, Commons, Betawikiversity) for thousands of edits. Live version can be installed for testing by importing en:User:Well very well/JWB.js/load.js.
In my opinion, due to the large changes (to the interface plus some changes in localization messages) this PR warrants a bump to major version. If this would be accepted, I will also file PRs for smaller new features that ruwiki users have asked me for (a few new buttons, checks for local flags, and possibly allowing autosave from a non-bot account).
Closes #32
Interface example:
