Skip to content

Correctly align snackbars in Login / CreateAccount activities. #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Correctly align snackbars in Login / CreateAccount activities. #5720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db781de
Correctly align snackbars in Login / CreateAccount activities.
dbrant Jun 25, 2025
a3fb51c
Merge branch 'main' into loginSnackbars
Williamrai Jun 25, 2025
369090c
Merge branch 'main' into loginSnackbars
Williamrai Jun 26, 2025
93e8ab9
Merge branch 'main' into loginSnackbars
Williamrai Jun 27, 2025
eac13e5
Merge branch 'main' into loginSnackbars
Williamrai Jul 11, 2025
9a47a66
Merge branch 'main' into loginSnackbars
Williamrai Jul 14, 2025
24fd5a9
Merge branch 'main' into loginSnackbars
Williamrai Jul 15, 2025
0d18a50
Merge branch 'main' into loginSnackbars
dbrant Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/java/org/wikipedia/util/FeedbackUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ import org.wikipedia.R
import org.wikipedia.WikipediaApp
import org.wikipedia.activity.BaseActivity
import org.wikipedia.analytics.eventplatform.BreadCrumbLogEvent
import org.wikipedia.createaccount.CreateAccountActivity
import org.wikipedia.databinding.ViewPlainTextTooltipBinding
import org.wikipedia.dataclient.WikiSite
import org.wikipedia.login.LoginActivity
import org.wikipedia.login.ResetPasswordActivity
import org.wikipedia.main.MainActivity
import org.wikipedia.page.LinkMovementMethodExt
import org.wikipedia.page.PageActivity
Expand Down Expand Up @@ -303,6 +306,7 @@ object FeedbackUtil {
is SuggestionsActivity -> R.id.suggestedEditsCardsCoordinator
is EditHistoryListActivity -> R.id.edit_history_coordinator
is TalkTopicsActivity -> R.id.talkTopicsSnackbar
is LoginActivity, CreateAccountActivity, ResetPasswordActivity -> R.id.layout_coordinator
else -> android.R.id.content
}
return ActivityCompat.requireViewById(activity, viewId)
Expand Down
5 changes: 3 additions & 2 deletions app/src/main/res/layout/activity_create_account.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/layout_coordinator"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fitsSystemWindows="true">
Expand Down Expand Up @@ -172,4 +173,4 @@
android:indeterminate="true"
android:visibility="gone"
tools:visibility="visible" />
</FrameLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
5 changes: 3 additions & 2 deletions app/src/main/res/layout/activity_login.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/layout_coordinator"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fitsSystemWindows="true">
Expand Down Expand Up @@ -146,4 +147,4 @@
android:visibility="gone"
tools:visibility="visible" />

</FrameLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
5 changes: 3 additions & 2 deletions app/src/main/res/layout/activity_reset_password.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/layout_coordinator"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:fitsSystemWindows="true">
Expand Down Expand Up @@ -108,4 +109,4 @@
android:visibility="gone"
tools:visibility="visible" />

</FrameLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
Loading