Remove allowMainThreadQueries and update DAO functions #5730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooltey
added
Ready to merge
|
This is ready for review. The changes affect all reading list saving behaviors in the app. |
This reverts commit 586d455.
Williamrai
reviewed
Jul 7, 2025
app/src/main/java/org/wikipedia/readinglist/ReadingListBehaviorsUtil.kt
Outdated
Show resolved
Hide resolved
Williamrai
reviewed
Jul 14, 2025
| @@ -77,30 +80,31 @@ object ReadingListsExportImportHelper : BaseActivity.Callback { | |||
| .setStyle(NotificationCompat.BigTextStyle().bigText(context.getString(R.string.reading_list_notification_text, numOfLists))) | |||
| } | |||
|
|
|||
| fun importLists(activity: BaseActivity, jsonString: String) { | |||
| fun importLists(activity: AppCompatActivity, jsonString: String) { | |||
There was a problem hiding this comment.
I'm wondering if it might be cleaner to convert this into a suspend function and launch it using viewLifecycleOwner.lifecycleScope in the fragment, instead of passing AppCompatActivity for launching the coroutine, what do you think? and maybe for other functions as well.
dbrant
requested changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T397993