espresso fixes and replacing manual smoke test #6150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds isItemPresent before scrolling with log
- code fixes, adds new test functions - github workflow updates to test on different api level and device
- adds two new function onParentViewWithChildIdAndText and selectTabWithText - code fixes
cooltey
reviewed
Dec 2, 2025
Comment on lines
+229
to
+246
| fun isItemPresent( | ||
| recyclerViewId: Int = R.id.feed_view, | ||
| title: String, | ||
| textViewId: Int = R.id.view_card_header_title | ||
| ): Boolean { | ||
| return try { | ||
| onView(withId(recyclerViewId)) | ||
| .check(matches(hasDescendant(allOf( | ||
| withId(textViewId), | ||
| withText(title) | ||
| )))) | ||
| true | ||
| } catch (_: NoMatchingViewException) { | ||
| false | ||
| } catch (_: AssertionFailedError) { | ||
| false | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
this was used before but its not used now, there are lot of functions which are not used or i added for testing. I will remove them and refactor more after i finish fixing the tests.
| }) | ||
| } | ||
|
|
||
| private fun verifyItemAtPosition( |
Collaborator
There was a problem hiding this comment.
Same for this, is this still being used? and also this findItemPosition
Collaborator
Author
There was a problem hiding this comment.
this was used before but its not used now, there are lot of functions which are not used or i added for testing. I will remove them and refactor more after i finish fixing the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Phabricator:
https://phabricator.wikimedia.org/T378649