Skip to content

Propagate exit code when running post-install hook #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Propagate exit code when running post-install hook #244

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96de012
Propagate error when merging config
harnash Aug 22, 2022
baa98e7
Merge pull request #1 from Wikia/propagate_status_code
harnash Aug 26, 2022
6cc1b74
Merge branch 'wikimedia:master' into master
harnash Aug 30, 2022
d6b8330
Merge branch 'wikimedia:master' into master
harnash Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/MergePlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,9 @@ public function onPostInstallOrUpdate(ScriptEvent $event)
'</error>'
);
file_put_contents($lock, $lockBackup);
// propagate error to the parent process to allow proper status code being returned
// this is important for any CI/CD tools to properly recognize if an error occurred in this phase
exit($status);
}
}
// @codeCoverageIgnoreEnd
Expand Down