#255 the load function does not fail the promise correctly #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankari
approved these changes
Jun 8, 2023
Author
|
ok |
winstonsung
suggested changes
Jun 14, 2023
Contributor
winstonsung
left a comment
winstonsung
left a comment
There was a problem hiding this comment.
Please do not change the whitespace format.
Author
|
Can you merge my changes |
Contributor
|
I am not a maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#255 the load function does not fail the promise correctly
handle the 404 exceptions
if (jqxhr.status === 404) {
// Ignore 404 exception, because we are handling fallbacks explicitly
deferred.resolve();
} else {
$.i18n.log(
"Error in loading messages from " + url + " Exception: " + exception
);
deferred.reject(exception);
}