Add a typescript declaration file #275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: T348794
Member
|
Thanks for your contribution. Would it be possible to add tests for these typings as well? Banana.i18n is the successor of this library, and that library also has typings. You can refer the typing tests in the repo: https://github.com/wikimedia/banana-i18n/tree/master/types Tests not only verify the work you did, but also act as example reference to use the type definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T348794
Did my best to infer the types based on the code, I think I got the types pretty accurate. One thing I'm not too sure about is
MessageStore.load- I copied the overloads straight fromI18N.load, since it seems like they both take the same input.