Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/languages/language.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,16 @@ pub trait Language {
// Pre-calculate all paragraph offsets in one pass
let mut paragraph_offsets = Vec::with_capacity(paragraphs.len());
let mut current_offset = 0;
let mut paragraph_char_offsets = Vec::with_capacity(paragraphs.len());
let mut current_char_offset = 0;
for (i, paragraph) in paragraphs.iter().enumerate() {
paragraph_offsets.push(current_offset);
paragraph_char_offsets.push(current_char_offset);
current_offset += paragraph.len();
current_char_offset += paragraph.chars().count();
if i < paragraphs.len() - 1 {
current_offset += 2; // for "\n\n"
current_char_offset += 2;
}
}

Expand All @@ -106,11 +111,12 @@ pub trait Language {
for (pindex, paragraph) in paragraphs.iter().enumerate() {
if pindex > 0 {
let paragraph_start = paragraph_offsets[pindex];
let paragraph_char_start = paragraph_char_offsets[pindex];
boundaries.push(SentenceBoundary {
start_index: paragraph_start,
end_index: paragraph_start + 2,
start_byte: paragraph_start,
end_byte: paragraph_start + 2,
start_index: paragraph_char_start - 2,
end_index: paragraph_char_start,
start_byte: paragraph_start - 2,
end_byte: paragraph_start,
text: "\n\n",
boundary_symbol: None,
is_paragraph_break: true,
Expand All @@ -120,8 +126,15 @@ pub trait Language {
let paragraph_start_offset = if pindex == 0 {
0
} else {
paragraph_offsets[pindex] + 2
paragraph_offsets[pindex]
};

let paragraph_start_char_offset = if pindex == 0 {
0
} else {
paragraph_char_offsets[pindex]
};

sentence_boundaries.clear();
sentence_boundaries.push(0);

Expand Down Expand Up @@ -200,9 +213,10 @@ pub trait Language {
let start_byte = paragraph_start_offset + start;
let end_byte = paragraph_start_offset + end;

let start_index = paragraph[..paragraph.floor_char_boundary(start_byte)]
.chars()
.count();
let start_index = paragraph_start_char_offset
+ paragraph[..paragraph.floor_char_boundary(start)]
.chars()
.count();
let end_index = start_index + sentence_text.chars().count();

boundaries.push(SentenceBoundary {
Expand Down
35 changes: 35 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -362,4 +362,39 @@ mod tests {
let small_result = segment("en", small_text);
assert_eq!(small_result, expected_per_repetition);
}

#[test]
fn test_get_sentence_boundaries_with_paragraph_breaks() {
let text = "Title\n\nSentence 1.\n\nSentence 2.";
let boundaries = get_sentence_boundaries("en", text);

// Should have at least 2 sentences plus paragraph breaks
assert!(boundaries.len() >= 2);

// Verify indices are consistent
for i in 1..boundaries.len() {
assert!(
boundaries[i].start_index >= boundaries[i - 1].end_index,
"Boundary {} starts at {} but previous ends at {}",
i,
boundaries[i].start_index,
boundaries[i - 1].end_index
);
}

// Verify text can be reconstructed
let reconstructed: String = boundaries.iter().map(|b| b.text).collect();
assert_eq!(
reconstructed, text,
"Reconstructed text doesn't match original"
);

// Check that paragraph breaks are detected
let paragraph_breaks: Vec<_> = boundaries.iter().filter(|b| b.is_paragraph_break).collect();
assert!(
paragraph_breaks.len() >= 2,
"Expected at least 2 paragraph breaks, found {}",
paragraph_breaks.len()
);
}
}
Loading