fix(nodejs): Correct exports require mapping to use index.cjs#39
Merged
santhoshtr merged 1 commit intomasterfrom Jan 19, 2026
Merged
fix(nodejs): Correct exports require mapping to use index.cjs#39santhoshtr merged 1 commit intomasterfrom
santhoshtr merged 1 commit intomasterfrom
Conversation
Fix package.json exports to use './index.cjs' instead of './index.node' for CommonJS require() statements. The native binary (index.node) should not be directly required as it doesn't provide platform detection. The index.cjs wrapper properly: - Detects platform and architecture - Loads the correct platform-specific binary - Provides helpful error messages for unsupported platforms Fixes #36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #36 - Node.js package.json has incorrect CommonJS require mapping.
Changes
"require": "./index.node"to"require": "./index.cjs"in exports configurationWhy This Matters
index.nodeis a native ELF binary without platform detectionindex.cjsis the correct CommonJS wrapper that:Impact
require("sentencex")fails across platformsTesting
index.mjs)