Show login prompt even if they dismissed it in previous experiment#5673
Merged
mazevedofs merged 1 commit intomainfrom Feb 6, 2026
Merged
Show login prompt even if they dismissed it in previous experiment#5673mazevedofs merged 1 commit intomainfrom
mazevedofs merged 1 commit intomainfrom
Conversation
- Otherwise user might see fully blank view
mazevedofs
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T416230
Notes
On one of my devices I saw a fully blank activity tab. I think because we removed timeline, but it still had a user defaults flag suppressing the login prompt. I am removing the persistence logic for the login prompt to avoid this situation.
Test Steps