Skip to content

T416230: Remove + disable timeline of behavior for logged out #5678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonisevener merged 2 commits into from
Feb 10, 2026
Merged

T416230: Remove + disable timeline of behavior for logged out #5678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda04e7
Remove + disable timeline of behavior for logged out
Feb 9, 2026
4d10ce2
Merge branch 'main' into T416230
l-olson1214 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../WMFComponents/Components/Activity Tab/View Models/WMFActivityTabCustomizeViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public final class WMFActivityTabCustomizeViewModel: ObservableObject {
let isTimeSpentReadingOn = isLoggedIn ? await dataController.isTimeSpentReadingOn : false
let isReadingInsightsOn = isLoggedIn ? await dataController.isReadingInsightsOn : false
let isEditingInsightsOn = isLoggedIn ? await dataController.isEditingInsightsOn : false
let isTimelineOfBehaviorOn = await dataController.isTimelineOfBehaviorOn
let isTimelineOfBehaviorOn = isLoggedIn ? await dataController.isTimelineOfBehaviorOn : false

self.isTimeSpentReadingOn = isTimeSpentReadingOn
self.isReadingInsightsOn = isReadingInsightsOn
Expand Down Expand Up @@ -82,11 +82,11 @@ public final class WMFActivityTabCustomizeViewModel: ObservableObject {

$isTimelineOfBehaviorOn
.sink { [weak self] value in
guard let self else { return }
guard let self, self.isLoggedIn else { return }

Task {
await self.dataController.updateIsTimelineOfBehaviorOn(value)
}

}
.store(in: &cancellables)
}
Expand Down
8 changes: 8 additions & 0 deletions ...omponents/Sources/WMFComponents/Components/Activity Tab/WMFActivityTabCustomizeView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ public struct WMFActivityTabCustomizeView: View {
isOn: $viewModel.isTimelineOfBehaviorOn
)
.listRowBackground(Color(theme.paperBackground).edgesIgnoringSafeArea([.all]))
.onChange(of: viewModel.isTimelineOfBehaviorOn) { newValue in
guard newValue == true else { return }
guard viewModel.isLoggedIn else {
viewModel.isTimelineOfBehaviorOn = false
viewModel.presentLoggedInToastAction?()
return
}
}
} footer: {
Text(viewModel.localizedStrings.footer)
.font(Font(WMFFont.for(.caption1)))
Expand Down
7 changes: 1 addition & 6 deletions WMFComponents/Sources/WMFComponents/Components/Activity Tab/WMFActivityTabView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@ public struct WMFActivityTabView: View {
loggedInList(proxy: proxy)
}
} else {
if !viewModel.customizeViewModel.isTimelineOfBehaviorOn {
customizedEmptyState()
} else {
loggedOutList(proxy: proxy)
}
loggedOutList(proxy: proxy)
}
}
}
Expand Down Expand Up @@ -188,7 +184,6 @@ public struct WMFActivityTabView: View {
private func loggedOutList(proxy: ScrollViewProxy) -> some View {
if viewModel.sections.count == 0 {
VStack {

Section {
loggedOutView
.accessibilityElement(children: .contain)
Expand Down
Loading