Add ServerCallContext #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was introduced in a2aproject/a2a-java#206
fjuma
reviewed
Jul 29, 2025
| if (callContextFactory.isUnsatisfied()) { | ||
| User user; | ||
|
|
||
| if (securityContext.getUserPrincipal() != null) { |
Contributor
There was a problem hiding this comment.
should this be == null instead of != null since the user is being set to UnauthenticatedUser.INSTANCE below
fjuma
reviewed
Jul 29, 2025
|
|
||
| @Override | ||
| public String getUsername() { | ||
| return request.getUserPrincipal().getName(); |
Contributor
There was a problem hiding this comment.
Should securityContext.getUserPrincipal() be used here instead?
kabir
force-pushed
the
align-with-a2a-java
branch
from
62473e4 to
98da0ae
Compare
fjuma
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was introduced in a2aproject/a2a-java#206