Skip to content

Conversation

@MarcoBau
Copy link

@fjuma fjuma changed the base branch from 1.19.x to 2.x September 18, 2024 14:05
@fjuma fjuma changed the base branch from 2.x to 1.19.x September 18, 2024 14:05
@fjuma
Copy link
Contributor

fjuma commented Sep 18, 2024

Please update the base branch for this PR to 2.x.

If you could also add a test for this, that would be great.

Thanks!

@MarcoBau
Copy link
Author

Hi,
we need that change in the 1.19.x branch.
I can open another MR to the 2.x branch if you want.

I'm checking how I could write a meaningful test around that change

@MarcoBau
Copy link
Author

The method getDiscoveryUrl() where the change is done is private and its result is never exposed in a way a test could be written to check its result.
The only way I see to test it is to relax the method's visibility making it package protected. Should I proceed with a change like that or do you have another suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants