Fix search #2202
Open
Fix search #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: includes: #2056 with an update to lunr.js and some minor fixes. |
Contributor
Author
|
Note I have no idea how to get this to deploy to GH pages for preview, I've tested it locally and it works fine. |
Contributor
|
Hello @luck3y really nice work :) to test your branch in GH pages, see the step 3 in the README https://github.com/wildfly-security/wildfly-elytron/tree/gh-pages |
Contributor
Author
|
Thanks @gabrielpadilh4 that worked great! |
Contributor
|
Thank you @luck3y one comment, when the page is first displayed should we have the default view of blog posts there? I am seeing a blank section under the search box. |
Contributor
Author
|
@darranl I don't think that happens locally, will look at whats going on in the preview and update it. |
ELY-2394 Add the ability to search for blog posts on the Elytron Blog…
Contributor
|
@luck3y if this PR was fixed, it needs a rebase now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ELY-2394
Preview: https://luck3y.github.io/wildfly-elytron/blog/
Signed-Off-By: Ken Wills [email protected]