-
Notifications
You must be signed in to change notification settings - Fork 292
ELY-2872 - Security roles lost following failover #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pedro-hos Thanks for your PR! Just noticed that the PR is currently referencing a WFLY issue instead of an ELY issue. Please move the WFLY issue to the ELY project and update the PR title and commit to reference the ELY issue instead. Please also submit this PR against the 2.6.x branch instead of the 2.x branch. Thanks! |
@fjuma Thank you for your feedback. I think that this is ok now. I moved from 2.x to 2.6.x and created the new ELY issue |
|
@pedro-hos FYI this PR currently have a merge conflict, but also I think we are ready to look at where a test case can live for this scenario - the changes I made previously to Elytron Web may be possible to be extended to add this kind of scenario. |
Skyllarr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note here that a PR with a test is here: wildfly-security/elytron-web#285
wildfly-elytron/pom.xml
Outdated
| <groupId>org.wildfly.security</groupId> | ||
| <artifactId>wildfly-elytron</artifactId> | ||
| <version>2.6.3.Final</version> <!-- When updating to next release, clear all exclusions. --> | ||
| <version>2.6.4.Final</version> <!-- When updating to next release, clear all exclusions. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pedro-hos , this PR should not change the version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Skyllarr
|
@pedro-hos I needed to rewrite a commit message here so it contains ELY issue number and add a fix on top of this. So I submitted #2294 that supersedes this PR |
|
@Skyllarr May we close this one so? |
|
Superseded by #2294 |
1 similar comment
|
Superseded by #2294 |
Uh oh!
There was an error while loading. Please reload this page.