Skip to content

Conversation

@pedro-hos
Copy link
Contributor

@pedro-hos pedro-hos commented Dec 17, 2024

@fjuma
Copy link
Contributor

fjuma commented Jan 15, 2025

@pedro-hos Thanks for your PR! Just noticed that the PR is currently referencing a WFLY issue instead of an ELY issue. Please move the WFLY issue to the ELY project and update the PR title and commit to reference the ELY issue instead.

Please also submit this PR against the 2.6.x branch instead of the 2.x branch.

Thanks!

@pedro-hos pedro-hos changed the base branch from 2.x to 2.6.x January 27, 2025 16:49
@pedro-hos pedro-hos changed the title WFLY-18650 - Security roles lost following failover ELY-2872 - Security roles lost following failover Jan 27, 2025
@pedro-hos pedro-hos changed the base branch from 2.6.x to 2.x January 27, 2025 16:53
@pedro-hos pedro-hos changed the base branch from 2.x to 2.6.x January 27, 2025 17:21
@pedro-hos
Copy link
Contributor Author

@pedro-hos Thanks for your PR! Just noticed that the PR is currently referencing a WFLY issue instead of an ELY issue. Please move the WFLY issue to the ELY project and update the PR title and commit to reference the ELY issue instead.

Please also submit this PR against the 2.6.x branch instead of the 2.x branch.

Thanks!

@fjuma Thank you for your feedback. I think that this is ok now. I moved from 2.x to 2.6.x and created the new ELY issue

@darranl
Copy link
Contributor

darranl commented Jun 12, 2025

@pedro-hos FYI this PR currently have a merge conflict, but also I think we are ready to look at where a test case can live for this scenario - the changes I made previously to Elytron Web may be possible to be extended to add this kind of scenario.

Copy link
Contributor

@Skyllarr Skyllarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note here that a PR with a test is here: wildfly-security/elytron-web#285

<groupId>org.wildfly.security</groupId>
<artifactId>wildfly-elytron</artifactId>
<version>2.6.3.Final</version> <!-- When updating to next release, clear all exclusions. -->
<version>2.6.4.Final</version> <!-- When updating to next release, clear all exclusions. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pedro-hos , this PR should not change the version here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Skyllarr

@Skyllarr
Copy link
Contributor

@pedro-hos I needed to rewrite a commit message here so it contains ELY issue number and add a fix on top of this. So I submitted #2294 that supersedes this PR

@pedro-hos
Copy link
Contributor Author

@Skyllarr May we close this one so?

@Skyllarr
Copy link
Contributor

Superseded by #2294

1 similar comment
@Skyllarr
Copy link
Contributor

Superseded by #2294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants