[ELY-2961] update poms, tests, workflow. Disable unit test, Alternat… #2344
Conversation
|
Need to wait for future code changes related to the replacement of security manager code. |
|
@rsearls I've added hold label based on your last comment |
|
Agreed |
|
@rsearls No need to close it, it is okay opened with hold label. Or you can convert it to draft if it will have changes later |
|
Before merging this, it should be rebased after #2345 is merged. |
rsearls
force-pushed
the
ELY-2961-JDK-24-bld-2.x
branch
2 times, most recently
from
c8301ba to
8712218
Compare
rsearls
force-pushed
the
ELY-2961-JDK-24-bld-2.x
branch
from
8712218 to
ff06cec
Compare
rsearls
force-pushed
the
ELY-2961-JDK-24-bld-2.x
branch
from
ae716c5 to
46bea79
Compare
| Assert.assertEquals(1, defaultSSLContext.createSSLEngine().getSSLParameters().getProtocols().length); | ||
| Assert.assertEquals(1, defaultSSLContext.getSocketFactory().getSupportedCipherSuites().length); | ||
| // jdk-24+ does not support the TLS_RSA_* cipher suite by default. In this scenario nothing is returned. | ||
| Assert.assertEquals(0, defaultSSLContext.getSocketFactory().getSupportedCipherSuites().length); |
There was a problem hiding this comment.
@rsearls Should there be some kind of if-else that checks the version of java before this assertEquals?
There was a problem hiding this comment.
There is no need. The supported security protocol and corresponding cipher suites
are determined at the JDK level. I have verified that these assertions are
valid for jdk-17 thru jdk-25.
|
@rsearls there is a pom.xml conflict now that needs rebase, otherwise I approved the changes. Thank you! |
…SecurityManagerTest to run JDK-24+
rsearls
force-pushed
the
ELY-2961-JDK-24-bld-2.x
branch
from
46bea79 to
8ee20a0
Compare
|
Rebase complete |
3 participants
…eSecurityManagerTest to run JDK-24+
https://issues.redhat.com/browse/ELY-2961