Fix some stuff with large files and file collections#86
Closed
ApfelTeeSaft wants to merge 2 commits intowimpysworld:mainfrom
Closed
Fix some stuff with large files and file collections#86ApfelTeeSaft wants to merge 2 commits intowimpysworld:mainfrom
ApfelTeeSaft wants to merge 2 commits intowimpysworld:mainfrom
Conversation
Member
|
@cubic review this pull request |
Contributor
@flexiondotorg I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
flexiondotorg
added a commit
that referenced
this pull request
Jan 22, 2026
- Add automatic retry mechanism with exponential backoff (3 retries max) - Implement automatic resume on retry by re-checking file size - Extend connection timeout to 10 minutes for large file downloads - Add connection pooling and TCP keepalive settings - Refactor download_file_content to handle transient network errors - Simplify function signature by removing explicit file_size parameter Addresses issues: - #76: Large files downloading with incorrect size/hash errors - #89: Connection errors during download ('error decoding response body') Changes from PR #86 by @ApfelTeeSaft
flexiondotorg
added a commit
that referenced
this pull request
Jan 22, 2026
- Add automatic retry mechanism with exponential backoff (3 retries max) - Implement automatic resume on retry by re-checking file size - Extend connection timeout to 10 minutes for large file downloads - Add connection pooling and TCP keepalive settings - Refactor download_file_content to handle transient network errors - Simplify function signature by removing explicit file_size parameter Addresses issues: - #76: Large files downloading with incorrect size/hash errors - #89: Connection errors during download ('error decoding response body') Changes from PR #86 by @ApfelTeeSaft
Member
|
Thanks @ApfelTeeSaft 🙇 This pull request was incorporated in #91 |
flexiondotorg
added a commit
that referenced
this pull request
Jan 22, 2026
* feat: add retry logic and extended timeouts for large file downloads - Add automatic retry mechanism with exponential backoff (3 retries max) - Implement automatic resume on retry by re-checking file size - Extend connection timeout to 10 minutes for large file downloads - Add connection pooling and TCP keepalive settings - Refactor download_file_content to handle transient network errors - Simplify function signature by removing explicit file_size parameter Addresses issues: - #76: Large files downloading with incorrect size/hash errors - #89: Connection errors during download ('error decoding response body') Changes from PR #86 by @ApfelTeeSaft * fix: use HTTP_TIMEOUT constant instead of magic number --------- Co-authored-by: Martin Wimpress <martin@wimpress.org> Co-authored-by: cubic-dev-ai[bot] <1082092+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.