fix: sanitize filenames for cross-platform compatibility#93
Merged
flexiondotorg merged 1 commit intomainfrom Jan 22, 2026
Merged
fix: sanitize filenames for cross-platform compatibility#93flexiondotorg merged 1 commit intomainfrom
flexiondotorg merged 1 commit intomainfrom
Conversation
- Add sanitize_filename() function to utils.rs that replaces invalid filesystem characters (< > : " | ? * and control characters) with underscores - Handle Windows reserved names (CON, PRN, AUX, NUL, COM1-9, LPT1-9) by inserting underscore before extension - Preserve directory structure in filenames with path separators - Trim leading/trailing spaces and trailing dots from path components - Apply sanitization in main.rs before downloading files - Display warnings when filenames are modified with before/after - Show summary count of sanitized files - Add comprehensive unit tests covering edge cases Fixes #63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
Summary by cubic
Sanitizes filenames before download to ensure cross-platform compatibility and prevent filesystem errors (fixes #63).
Written for commit b476e8a. Summary will update on new commits.