fix: apply RTL formatting based on langTo in popup, fixes #1365#1366
Merged
windingwind merged 1 commit intowindingwind:mainfrom Jan 27, 2026
Merged
fix: apply RTL formatting based on langTo in popup, fixes #1365#1366windingwind merged 1 commit intowindingwind:mainfrom
windingwind merged 1 commit intowindingwind:mainfrom
Conversation
Contributor
ramonmi
commented
Dec 21, 2025
ramonmi
commented
- For non-RTL locales (i.e., not ar, fa, or he), the textarea (the type of Popup, rather than editable-text) defaults to LTR, even if the target language of the translation is one of them.
- This PR sets the RTL mode explicitly, depending on the target language.
ramonmi
force-pushed
the
translate-patch-40
branch
from
a5e59f4 to
ddad65b
Compare
Contributor
|
@ramonmi npm run lintand push the results? Thanks! |
Contributor
|
🚀 This ticket has been resolved in v2.4.2. See Release v2.4.2 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.