Skip to content

Conversation

@pyranota
Copy link
Contributor

@pyranota pyranota commented Jan 6, 2026

Screenshot 2026-01-06 at 13-00-01 Run 019b932d-971f-129b-eaeb-261c07b8e59f Windmill Screenshot 2026-01-06 at 13-00-11 Run 019b932d-971f-129b-eaeb-261c07b8e59f Windmill

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2026

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 57efa22
Status: ✅  Deploy successful!
Preview URL: https://601bdd0e.windmill.pages.dev
Branch Preview URL: https://debouncing-logs.windmill.pages.dev

View logs

Signed-off-by: pyranota <[email protected]>
Signed-off-by: pyranota <[email protected]>
@pyranota pyranota marked this pull request as ready for review January 6, 2026 12:06
@claude
Copy link
Contributor

claude bot commented Jan 6, 2026

Claude finished @pyranota's task in 1m 46s —— View job


Reviewing PR #7501

  • Gather context from changed files
  • Analyze before/after screenshots
  • Review code changes for quality and correctness
  • Provide comprehensive feedback
  • Add testing instructions

Summary

This PR improves visibility when debouncing accumulates arguments by adding a log message to the job logs. When debounced jobs have arguments accumulated (merged into a single execution), users will now see a clear message showing what value replaced the accumulated argument.

Code Review

Changes in backend/windmill-queue/src/jobs.rs:

The change adds user-facing log output when debounced arguments are substituted. Before this change, the substitution happened silently (only with a tracing::debug for developers). Now users can see in their job logs:

Substituting `{arg_name}` with: {value}

Assessment: ✅ Looks good

The implementation is clean and follows existing patterns in the codebase:

  1. Correct usage of append_logs - The function signature append_logs(&job_id, &workspace_id, message, &conn) is used correctly
  2. Efficient code reuse - The new_value variable is now extracted before the log call and reused in the insert, avoiding computing to_raw_value(&accumulated_arg) twice (though the compiler likely optimized this anyway, making it explicit is cleaner)
  3. Formatting - The log message includes a trailing newline (\n\n) which provides good visual separation in job logs

Minor observations:

  1. The log message displays the raw JSON value directly. For very large accumulated arrays, this could make logs verbose. However, this is likely intentional for debugging purposes and matches the spirit of the PR (better visibility).

  2. The &new_value in the format macro works because RawValue implements Display, showing the JSON representation. This is appropriate for the use case.

Security & Performance

  • Security: No concerns - this is a logging enhancement with no security implications
  • Performance: Minimal impact - append_logs is already called in this code path for other purposes, and the additional formatting is negligible

Testing Instructions

To verify this change, navigate to a script or flow in the Windmill UI that has debouncing enabled with argument accumulation configured (via the "Debouncing" settings in the script/flow configuration). Trigger the script/flow multiple times within the debounce window with list arguments. When the debounced job finally executes, open the job logs and you should see a message like "Substituting {argument_name} with: [...]" showing the accumulated values that replaced the original argument.


pyranota and others added 2 commits January 6, 2026 13:07
Signed-off-by: pyranota <[email protected]>
This commit updates the EE repository reference after PR #373 was merged in windmill-ee-private.

Previous ee-repo-ref: 1196ee50bfdbc8c9fd5220d6e324334dd41293a5

New ee-repo-ref: ea468d0b673257c694203517b0c5df52d9cb70dd

Automated by sync-ee-ref workflow.
@windmill-internal-app
Copy link
Contributor

🤖 Updated ee-repo-ref.txt to ea468d0b673257c694203517b0c5df52d9cb70dd after windmill-ee-private PR #373 was merged.

@rubenfiszel rubenfiszel merged commit 1bbf8c2 into main Jan 6, 2026
6 checks passed
@rubenfiszel rubenfiszel deleted the debouncing-logs branch January 6, 2026 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants