-
Notifications
You must be signed in to change notification settings - Fork 878
nit: better logs for debouncing [merge-ee-first] #7501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pyranota
commented
Jan 6, 2026
Signed-off-by: pyranota <[email protected]>
Deploying windmill with
|
| Latest commit: |
57efa22
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://601bdd0e.windmill.pages.dev |
| Branch Preview URL: | https://debouncing-logs.windmill.pages.dev |
Signed-off-by: pyranota <[email protected]>
…nto debouncing-logs Signed-off-by: pyranota <[email protected]>
Signed-off-by: pyranota <[email protected]>
|
Claude finished @pyranota's task in 1m 46s —— View job Reviewing PR #7501
SummaryThis PR improves visibility when debouncing accumulates arguments by adding a log message to the job logs. When debounced jobs have arguments accumulated (merged into a single execution), users will now see a clear message showing what value replaced the accumulated argument. Code ReviewChanges in The change adds user-facing log output when debounced arguments are substituted. Before this change, the substitution happened silently (only with a Assessment: ✅ Looks good The implementation is clean and follows existing patterns in the codebase:
Minor observations:
Security & Performance
Testing InstructionsTo verify this change, navigate to a script or flow in the Windmill UI that has debouncing enabled with argument accumulation configured (via the "Debouncing" settings in the script/flow configuration). Trigger the script/flow multiple times within the debounce window with list arguments. When the debounced job finally executes, open the job logs and you should see a message like "Substituting |
Signed-off-by: pyranota <[email protected]>
This commit updates the EE repository reference after PR #373 was merged in windmill-ee-private. Previous ee-repo-ref: 1196ee50bfdbc8c9fd5220d6e324334dd41293a5 New ee-repo-ref: ea468d0b673257c694203517b0c5df52d9cb70dd Automated by sync-ee-ref workflow.
|
🤖 Updated |