Skip to content

feat: store hashed tokens instead of plaintext #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenfiszel merged 38 commits into from
Mar 17, 2026
+1,723 −541
Merged

feat: store hashed tokens instead of plaintext #8217

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
c65b4b2
feat: store hashed tokens in the token table instead of plaintext
rubenfiszel Mar 4, 2026
c5780f2
fix: address review issues in token hash migration
rubenfiszel Mar 4, 2026
790a18c
fix: restore sqlx offline cache (only add new query files)
rubenfiszel Mar 4, 2026
e2103d9
refactor: keep writing plaintext token column for backward compat
rubenfiszel Mar 4, 2026
23bc2c4
feat: branch on MIN_VERSION to write plaintext token or null
rubenfiszel Mar 4, 2026
3153103
fix: set MIN_VERSION_SUPPORTS_TOKEN_HASH to 1.650.0
rubenfiszel Mar 4, 2026
5d549f9
merge: update branch with origin/main
hugocasa Mar 12, 2026
742fa00
fix: use token_hash for email lookup and expiry notifications
hugocasa Mar 12, 2026
9436506
Merge remote-tracking branch 'origin/main' into store-hash
hugocasa Mar 13, 2026
b607c5c
refactor: rotate webhook tokens instead of recovering plaintext from DB
hugocasa Mar 13, 2026
24fa52b
refactor: use token_hash for native trigger token lookups and deletes
hugocasa Mar 13, 2026
98077ca
sqlx
hugocasa Mar 13, 2026
5cbdcbf
refactor: drop webhook_token_prefix from native_trigger table
hugocasa Mar 13, 2026
3d9d35e
fix: backward compat for token rotation and make webhook_token_hash N…
hugocasa Mar 13, 2026
37ec2e5
fix: prevent panic on short superadmin secret token prefix
hugocasa Mar 13, 2026
5491608
fix: prevent panic on short superadmin secret token prefix
github-actions[bot] Mar 13, 2026
442e028
fix: prevent panic on short token prefix slicing
github-actions[bot] Mar 13, 2026
9217090
Revert "fix: prevent panic on short superadmin secret token prefix"
hugocasa Mar 13, 2026
07465a1
revert: remove unnecessary defensive token prefix slicing
hugocasa Mar 13, 2026
3f95be3
fix: add token_hash to end_user_email test fixture
hugocasa Mar 13, 2026
c33614f
test: add integration tests for token hash migration
hugocasa Mar 13, 2026
ba94f8e
fix: correct token_hash test assertions for cache and version
hugocasa Mar 13, 2026
48c27b3
chore: add plaintext column removal reminder to test fixtures
hugocasa Mar 13, 2026
dbe7d53
fix: log count of orphaned triggers deleted during migration
hugocasa Mar 13, 2026
0385a97
fix: preserve orphaned triggers with error instead of deleting
hugocasa Mar 13, 2026
4e2ce09
fix: rename token_expiry_notification.token to token_hash and copy ow…
hugocasa Mar 13, 2026
30dc5f8
fix: hash existing plaintext values before renaming token_expiry_noti…
hugocasa Mar 13, 2026
978ee56
fix: remove unnecessary length check in token_expiry_notification mig…
hugocasa Mar 13, 2026
1291e6f
update dates and version
hugocasa Mar 16, 2026
d908650
Merge remote-tracking branch 'origin/main' into store-hash
hugocasa Mar 16, 2026
fdcfb79
updat ee ref + sqlx
hugocasa Mar 16, 2026
ec3d992
improve mcp migration
hugocasa Mar 16, 2026
25b0a5f
fix: atomic token rotation with rollback on trigger update failure
hugocasa Mar 16, 2026
d0443c0
higher min version
hugocasa Mar 16, 2026
d90d5dc
fix: defer old token deletion to avoid breaking triggers on update fa…
hugocasa Mar 16, 2026
80ee75a
chore: update ee-repo-ref to 2d0823a471014e2bc2d898c63518323946b7474f
windmill-internal-app[bot] Mar 17, 2026
f32cce5
Merge branch 'main' into store-hash
rubenfiszel Mar 17, 2026
cb144ef
fix: prevent panic on short tokens by using safe prefix extraction
github-actions[bot] Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...288b39ea7c802007f112eb3d62230d07abb6.json → ...38ac8507fc8b1a3427a6b94ffb15fe43a1fa.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...a27e233e60e18b3d35545005eb680701241f.json → ...85f937776a6b47cd99c648bb4d819d3cfe57.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...d42e7add6011c34d91761ba23e2c74c4032c.json → ...a182f3953150ade1756259b31a50e9308fce.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...87fd5724c299cb285f819a2561260404e513.json → ...408dd2aa4e47ef7a38a0d3ccca944a09f5bb.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...417c8a5aa7635be1dc0b37dc29d0f9e7c163.json → ...b7e169d07463f67f1da79c8bc23c1079c185.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions backend/.sqlx/query-20cb62341ead7414c14fc22e1ddbe3e5357ede31a4b3412668b6961e7c055795.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...5470cd5f1d4ddbb147cb8ce46f9d1da5dfaf.json → ...1a47475dcf1a388c613a9e0154aef6582a23.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions backend/.sqlx/query-223fbd972728d5b3ec5b1708e3f2e1f4901b0382fca50704c9544cdec5f9352c.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...23d8e54c96889e06895c57cafae9ca27bf8b.json → ...6f2e18cb911352551d0a34bf1933e558674e.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...821cf73ace9d6692750ccc4cca37701ed77a.json → ...4b936c3ffff44ae58f0709d05ba3ff534f79.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...d60e2364ba87263f962ed7d4329c916620a1.json → ...697cd321b397422a7c689b85216bbb1fd525.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions backend/.sqlx/query-4e88aec662ebc70e0425a48a1b4e2e60e3183fa81a411622891caea6dc03fa90.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...acbabed4c5ae28101e3ae2694f96fd055a91.json → ...27a85270c25c5a0f0d4d7670bd602bd3cebf.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 0 additions & 18 deletions backend/.sqlx/query-54756c6c39888feb2206b056df1c84c3bb44adc490309954359845c06b6e607c.json
View file
Open in desktop

This file was deleted.

20 changes: 20 additions & 0 deletions backend/.sqlx/query-54c0c20fe025d4fb45f04ff3389b25915f671e7c52426fc54b2fd533b90596e2.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions backend/.sqlx/query-58dc872520beaa914fef8b7f30e578261fb9ebd92a81e1f2c8edaf93cece0819.json
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions ...53a9f7be86ff752612909587ec3cb770cb75.json → ...86a4f4ea8880cc5d0b511aa70b6fd50072c5.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...01f29e58e81b3f782887db6e0a627dd8ad75.json → ...25bf2f3a35d90f7354c7d3aef8a3538a03a7.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading