Fix nonDottedPaths handling in cli flow lock generation#8375
Merged
rubenfiszel merged 2 commits intowindmill-labs:mainfrom Mar 15, 2026
Merged
Fix nonDottedPaths handling in cli flow lock generation#8375rubenfiszel merged 2 commits intowindmill-labs:mainfrom
rubenfiszel merged 2 commits intowindmill-labs:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wmill generate-metadata --lock-onlypreserve plain flow step filenames whennonDottedPaths: truesync pullbehavior for flowsProblem
With
nonDottedPaths: trueinwmill.yaml,wmill sync pull --yesexports flow steps as plain files like:a.tsa.lockBut
wmill generate-metadata --lock-onlyrewrites the same flow to:a.inline_script.tsa.inline_script.lockand updates
flow.yamlto point at those files.A subsequent
wmill sync pull --yeschanges the flow back to the plain filenames, so the repo churns back and forth depending on which command ran last.Fix
This updates flow metadata generation to pass
skipInlineScriptSuffix: getNonDottedPaths()tonewPathAssigner, matching the behavior already used by flow sync pull.Since the deprecated
wmill flow generate-lockspath reuses the same implementation, it benefits from the same fix as well.Testing
wmill generate-metadata --lock-onlywithnonDottedPaths: trueNote: this code was supported by gpt 5.4, but manually reviewed and tested.