Skip to content

Fix nonDottedPaths handling in cli flow lock generation#8375

Merged
rubenfiszel merged 2 commits intowindmill-labs:mainfrom
travisp:fix/inline-script
Mar 15, 2026
Merged

Fix nonDottedPaths handling in cli flow lock generation#8375
rubenfiszel merged 2 commits intowindmill-labs:mainfrom
travisp:fix/inline-script

Conversation

@travisp
Copy link
Contributor

@travisp travisp commented Mar 15, 2026

Summary

  • make wmill generate-metadata --lock-only preserve plain flow step filenames when nonDottedPaths: true
  • align flow lock generation with the existing sync pull behavior for flows
  • add a regression test covering the non-dotted flow layout

Problem

With nonDottedPaths: true in wmill.yaml, wmill sync pull --yes exports flow steps as plain files like:

  • a.ts
  • a.lock

But wmill generate-metadata --lock-only rewrites the same flow to:

  • a.inline_script.ts
  • a.inline_script.lock

and updates flow.yaml to point at those files.

A subsequent wmill sync pull --yes changes the flow back to the plain filenames, so the repo churns back and forth depending on which command ran last.

Fix

This updates flow metadata generation to pass skipInlineScriptSuffix: getNonDottedPaths() to newPathAssigner, matching the behavior already used by flow sync pull.
Since the deprecated wmill flow generate-locks path reuses the same implementation, it benefits from the same fix as well.

Testing

  • added a regression test for wmill generate-metadata --lock-only with nonDottedPaths: true
  • I personally confirmed the regression test fails without this change and passes with it

Note: this code was supported by gpt 5.4, but manually reviewed and tested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@travisp
Copy link
Contributor Author

travisp commented Mar 15, 2026

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 15, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rubenfiszel rubenfiszel merged commit eb03ebb into windmill-labs:main Mar 15, 2026
3 checks passed
@rubenfiszel
Copy link
Contributor

thanks a lot!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants