Skip to content

feat: instance groups instance-level role support#8404

Merged
rubenfiszel merged 4 commits intomainfrom
alp/instance_groups_super_admin
Mar 17, 2026
Merged

feat: instance groups instance-level role support#8404
rubenfiszel merged 4 commits intomainfrom
alp/instance_groups_super_admin

Conversation

@alpetric
Copy link
Collaborator

@alpetric alpetric commented Mar 16, 2026

Summary

  • Add ability to assign instance-level roles (superadmin/devops) to instance groups
  • Group members automatically receive the highest role from all their groups
  • Manual elevated roles (set by superadmin) always take precedence over group roles
  • Role propagation on all mutation paths: add/remove user, update/delete group, bulk import
  • Frontend: instance role toggle in group editor drawer, role column in tables, role source indicator in superadmin settings users list
  • DB migration adds instance_role to instance_group and role_source to password with CHECK constraints

Companion PR

Test plan

  • Create instance group, set instance role to devops/superadmin, verify members receive the role
  • Add/remove user from group with instance role, verify role updates
  • Manually set a user to superadmin, verify group changes don't override
  • Demote manually-elevated user to "user", verify group role takes over
  • Delete group with instance role, verify members are demoted
  • Verify "Set by instance group" indicator in superadmin settings
  • Verify SCIM sync propagates roles correctly

🤖 Generated with Claude Code

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 16, 2026

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3f09a6
Status: ✅  Deploy successful!
Preview URL: https://50b455bc.windmill.pages.dev
Branch Preview URL: https://alp-instance-groups-super-ad.windmill.pages.dev

View logs

@alpetric
Copy link
Collaborator Author

/updatesqlx

@windmill-internal-app
Copy link
Contributor

Starting sqlx update...

View workflow run

@windmill-internal-app
Copy link
Contributor

❌ SQLx update failed. Please check the workflow logs for details.

Add ability to assign instance-level roles (superadmin/devops) to
instance groups. Group members automatically receive the role with
proper precedence: manual elevated roles always win, superadmin > devops.

- Migration: add instance_role to instance_group, role_source to password
- Role propagation on all mutation paths (add/remove/update/delete/import)
- SCIM sync integration (companion PR: windmill-ee-private#463)
- Frontend: role toggle in group editor, role column in tables,
  role source indicator in superadmin settings

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit updates the EE repository reference after PR #463 was merged in windmill-ee-private.

Previous ee-repo-ref: b407fe4604153d09ff223e11d43c2df83a1de5d0

New ee-repo-ref: 278a3887f759f9d1146554baa0765518d5bc70f2

Automated by sync-ee-ref workflow.
@windmill-internal-app
Copy link
Contributor

🤖 Updated ee-repo-ref.txt to 278a3887f759f9d1146554baa0765518d5bc70f2 after windmill-ee-private PR #463 was merged.

@windmill-internal-app windmill-internal-app bot changed the title [ee] feat: instance groups instance-level role support feat: instance groups instance-level role support Mar 17, 2026
@rubenfiszel rubenfiszel merged commit 18b3528 into main Mar 17, 2026
10 of 12 checks passed
@rubenfiszel rubenfiszel deleted the alp/instance_groups_super_admin branch March 17, 2026 01:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants