Open
Conversation
Author
|
@wingkwong do you know if there's a good way to test that this works as expected before merging? -- also how would you feel about a bigger change that converts the project to TypeScript fully? |
julix-unity
force-pushed
the
julix91-add-types-file
branch
from
a8ec9be to
9f1d428
Compare
Author
|
Force pushed to use |
Owner
|
dist should be generated. I think this file should be gone after build? |
Author
It's only generated if the project is in typescript and the right tsconfig settings are there. How would it auto generate the file if it doesn't have types in main files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Types file as lib/react-quiz-component.d.ts and target in package.json
Closes #273
Credit to @d3vAdv3ntur3s for the writing of initial type file.