Skip to content

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 14, 2024

Built against PHP 8.3 and tested locally without noticing any issues (besides x86 builds are now level 1 warning clean).

Only minor issue is that apparently snmpd.pdb is no longer built, but I don't think a pdb for snmpd.exe is even relevant.

I suggest to roll this out to 8.4 and master, but only after php/php-src#15888 or a respective fix has been applied to php-src.

We re-apply our previous patches adapted as necessary, and also fix the
wrong version number (this is actually net-snmp 5.9.4, not 5.9.4.pre2).

We do not patch win32/net-snmp/net-snmp-config.h, though, but instead
rely on users to run `Configure`.
@cmb69
Copy link
Member Author

cmb69 commented Sep 30, 2024

The php-src PR has been merged, and given that the current version we're shipping (5.7.3) has its tenth birthday soon, I think we should update for PHP 8.4, 8.5 and master. @shivammathur, if you agree, could you please merge and upload?

@shivammathur shivammathur merged commit 0c47808 into master Sep 30, 2024
@cmb69 cmb69 deleted the cmb/5.9.4 branch September 30, 2024 10:19
@shivammathur
Copy link
Contributor

@cmb69 Done

@cmb69
Copy link
Member Author

cmb69 commented Sep 30, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants