refactor!: re-build winston-couchdb transport adapter#10
Open
DoomyTheFroomy wants to merge 1 commit intowinstonjs:masterfrom
Open
refactor!: re-build winston-couchdb transport adapter#10DoomyTheFroomy wants to merge 1 commit intowinstonjs:masterfrom
DoomyTheFroomy wants to merge 1 commit intowinstonjs:masterfrom
Conversation
The `winston-couchdb` was pretty outdated and not compatible anymore with current winston release. To enable the transport again, it was necessary to re-build the whole module. The two functions `query` and `stream` where implemented, but not tested. The documentation is not complete at this point. BREAKING CHANGE: - changed dependencies - changed necessary constructor attributes - the whole program code was changed - used the `abstract-winston-transport` package instead of `winston/test/transports/transport` (which is not available anymore) for test - added StandardJS for Code Styling - used `mocha` for testing instead of `vows` - bumped node engine to 12.0.0, which is the same as `winston` - used `main` instead of `master`, may be this can be changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
winston-couchdbwas pretty outdated and not compatible anymore with current winston release. To enable the transport again, it was necessary to re-build the whole module.The two functions
queryandstreamwhere implemented, but not tested. The documentation is not complete at this point. (Are they necessary anymore?)BREAKING CHANGE:
abstract-winston-transportpackage instead ofwinston/test/transports/transport(which is not available anymore) for testmochafor testing instead ofvowswinstonmaininstead ofmaster, may be this can be changed?